> On 25.11.2010, at 11:59, Paul Brook wrote: > >> This patch introduces configuration variables > >> CONFIG_SCSI_LSI > >> CONFIG_SCSI_MEGASAS > >> and renames the existing CONFIG_ESP to CONFIG_SCSI_ESP. > >> With this the available SCSI HBAs can be configured for each > >> target configuration instead of compiling it in for everyone. > > > > No. These are both PCI devices, I see no particularly good reason to make > > them optional. At minimum they should be enabled by default on all > > configs. > > > > The ESP controller is different because it is't a general purpose device, > > and only makes sense on certain systems. > > RH needs to compile out as much as they can from the code base, because > they state that they support everything that's compiled in. So making as > much as possible optional is good. And I don't see why we should limit > ourselves here.
My second point (should be enabled by default) still applies. Your patch removes the lsi controller from the default arm-softmmu config, which is definitely wrong. Paul
