On Tue, Aug 29, 2017 at 04:16:54PM -0500, Eric Blake wrote: > On 08/29/2017 12:42 PM, Stefan Hajnoczi wrote: > > On Tue, Aug 29, 2017 at 5:50 PM, Kashyap Chamarthy <kcham...@redhat.com> > > wrote: > >> This is the follow-up patch that was discussed[*] as part of feedback to > >> qemu-iotest 194. > >> > > >> Signed-off-by: Kashyap Chamarthy <kcham...@redhat.com> > >> --- > >> Changes in v3: > >> - Wait for migration to complete before issuing `block-job-cancel` > >> (StefanH) > >> - Wait for the event BLOCK_JOB_COMPLETED on the source before stopping > >> the NBD server on the destination (StefanH) > >> > >> Changes in v2: > >> - Check for both the events: MIGRATION and BLOCK_JOB_COMPLETED (EricB) > >> --- > >> tests/qemu-iotests/194 | 23 +++++++++++++++++------ > >> tests/qemu-iotests/194.out | 11 ++++++++--- > >> 2 files changed, 25 insertions(+), 9 deletions(-) > > > > Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> > > Thanks; I've added this to my NBD queue (pull request to come shortly > after 2.11 release is finalized), since the test uses NBD.
Sure, thanks for the quick reviews, both! -- /kashyap