On Tue, Aug 22, 2017 at 03:18:28PM +0200, Paolo Bonzini wrote: > +#ifdef CONFIG_LINUX > +PRManager *pr_manager_lookup(const char *id, Error **errp); > +#else > +static inline PRManager *pr_manager_lookup(const char *id, > + Error **errp)
Indentation > diff --git a/scsi/pr-manager.c b/scsi/pr-manager.c > new file mode 100644 > index 0000000000..e80f8d9b31 > --- /dev/null > +++ b/scsi/pr-manager.c > @@ -0,0 +1,109 @@ > +/* > + * Persistent reservation manager abstract class > + * > + * Copyright (c) 2017 Red Hat, Inc. > + * > + * Author: Paolo Bonzini <pbonz...@redhat.com> > + * > + * This code is licensed under the LGPL. > + * > + */ > + > +#include "qemu/osdep.h" > +#include "qapi/error.h" > +#include "block/aio.h" > +#include "block/thread-pool.h" > +#include "scsi/pr-manager.h" > +#include "scsi/trace.h" > + > +#include <scsi/sg.h> HACKING "1.2. Include directives" defines the order of #includes. It should be "qemu/osdep.h", <scsi/sg.h>, followed by all other QEMU headers.
