On Wed, 2017-08-30 at 17:01 +0100, Daniel P. Berrange wrote: > On Mon, Aug 21, 2017 at 03:49:05PM +0200, Gerd Hoffmann wrote: > > On Thu, 2017-08-10 at 16:55 +0100, Daniel P. Berrange wrote: > > > - virtio_input_key_config(vinput, keymap_qcode, > > > - ARRAY_SIZE(keymap_qcode)); > > > + virtio_input_key_config(vinput, qemu_input_map_qcode2linux, > > > + qemu_input_map_qcode2linux_len); > > > > That is a guest-visible change. > > Huh, really ?!?!? > > Are you saying the guest OS sees the raw qcode values ?
No. It'll see a bitmap of supported keys, and that will change. I'd suggest to just drop that patch for now, and when the dust has settled (qcode got all missing keys etc) flip it over, so we get away with a single compat property. cheers, Gerd
