On 04/09/17 11:01, Yi Min Zhao wrote: > I want to ask a question. According to the next patch, you check > bus->devices[devfn] > and reserved bit separately. Why not move the reserved bit check here? > I think bus->devices[devfn] != NULL or revsered bit set means slot is > unavailable.
Primarily it was to allow callers to distinguish between the two different cases i.e. the error message can tell you that the reason the slot was unavailable was because it was reserved, i.e. you can *never* plug anything into it compared with unavailable where someone has plugged something into the slot with -device but it could be later removed, for example with hotplug. ATB, Mark.
