* Fam Zheng (f...@redhat.com) wrote: > On Thu, 09/07 10:37, Dr. David Alan Gilbert wrote: > > * Fam Zheng (f...@redhat.com) wrote: > > > Signed-off-by: Fam Zheng <f...@redhat.com> > > > > OK, I've not actually got a preference as to whether it's > > per-object or not - I don't really see any advantage. > > Thanks for the review. You're right this probably doesn't make a difference > except for a bit more consistency, until we want to make rdma a module (as in > --enable-modules) like the ones in block layer. The -libs and -cflags > variables > were initially added just for that. > > While we are talking about it, is there any reason why that will not be a good > idea? There are other libraries used by QEMU outside block layer that are > overdue to be converted to modules, like ui (gtk, sdl, etc.), rdma seems to > be a > candidate too.
I don't think we've ever tried to make the migration code modular; it probably wouldn't be impossible to split it out - it's wired into a few places but it should be doable. Dave > Fam -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
