* Laurent Vivier (lviv...@redhat.com) wrote: > On 13/09/2017 16:27, Cornelia Huck wrote: > > On Wed, 13 Sep 2017 16:20:35 +0200 > > Laurent Vivier <lviv...@redhat.com> wrote: > > > >> From: Cornelia Huck <coh...@redhat.com> > >> > >> It does not really make sense to dump memory that is not there. > >> > >> Moreover, that fixes a segmentation fault when calling dump-guest-memory > >> with no filter for a machine with no memory defined. > >> > >> New behaviour is: > >> > >> (qemu) dump-guest-memory /dev/null > >> dump: no guest memory to dump > >> (qemu) dump-guest-memory /dev/null 0 4096 > >> dump: no guest memory to dump > >> > >> Signed-off-by: Cornelia Huck <coh...@redhat.com> > >> Tested-by: Laurent Vivier <lviv...@redhat.com> > >> Reviewed-by: Laurent Vivier <lviv...@redhat.com> > >> Reviewed-by: Greg Kurz <gr...@kaod.org> > >> Reviewed-by: Peter Xu <pet...@redhat.com> > >> --- > >> dump.c | 6 ++++++ > >> 1 file changed, 6 insertions(+) > > > > You need to supply your s-o-b as well, no? > > > > I was wondering... theoretically, yes, so: > > Signed-off-by: Laurent Vivier <lviv...@redhat.com>
Thanks. Dave > Thanks, > Laurent -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
