Hi, This series seems to have some coding style problems. See output below for more information:
Subject: [Qemu-devel] [PATCH RFC 0/6] xen: xen-domid-restrict improvements Message-id: 1505498999-17427-1-git-send-email-ian.jack...@eu.citrix.com Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' d0bf857e06 os-posix: Provide new -runasid option 569ba00e8f xen: destroy_hvm_domain: Try xendevicemodel_shutdown 1ef23a12d2 xen: destroy_hvm_domain: Move reason into a variable af7aac4055 xen: restrict: use xentoolcore_restrict_all b84c49e46a xen: defer call to xen_restrict until running 293b6b0146 xen: link against xentoolcore === OUTPUT BEGIN === Checking PATCH 1/6: xen: link against xentoolcore... Checking PATCH 2/6: xen: defer call to xen_restrict until running... Checking PATCH 3/6: xen: restrict: use xentoolcore_restrict_all... Checking PATCH 4/6: xen: destroy_hvm_domain: Move reason into a variable... Checking PATCH 5/6: xen: destroy_hvm_domain: Try xendevicemodel_shutdown... ERROR: braces {} are necessary for all arms of this statement #27: FILE: hw/i386/xen/xen-hvm.c:1395: + if (!rc) [...] total: 1 errors, 0 warnings, 18 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 6/6: os-posix: Provide new -runasid option... ERROR: consider using qemu_strtoul in preference to strtoul #41: FILE: os-posix.c:159: + lv = strtoul(optarg, &ep, 0); ERROR: do not use assignment in if condition #42: FILE: os-posix.c:160: + if (errno || *ep != '.' || (user_uid = lv) != lv ERROR: spaces required around that '+' (ctx:VxV) #48: FILE: os-posix.c:166: + lv = strtoul(ep+1, &ep, 0); ^ ERROR: consider using qemu_strtoul in preference to strtoul #48: FILE: os-posix.c:166: + lv = strtoul(ep+1, &ep, 0); ERROR: do not use assignment in if condition #49: FILE: os-posix.c:167: + if (errno || *ep || (user_gid = lv) != lv ERROR: space required after that ',' (ctx:WxV) #51: FILE: os-posix.c:169: + fprintf(stderr ,"Could not obtain gid from \"%s\"", optarg); ^ total: 6 errors, 0 warnings, 79 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@freelists.org