From: Lukáš Doktor <ldok...@redhat.com> The QMP key conversion consist of '_'s to be replaced with '-'s, which can easily be done by a single `str.replace` method which is faster and does not require `string` module import.
Signed-off-by: Lukáš Doktor <ldok...@redhat.com> Reviewed-by: Eduardo Habkost <ehabk...@redhat.com> Message-Id: <20170818142613.32394-5-ldok...@redhat.com> Reviewed-by: Cleber Rosa <cr...@redhat.com> Signed-off-by: Eduardo Habkost <ehabk...@redhat.com> --- scripts/qemu.py | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/scripts/qemu.py b/scripts/qemu.py index d8c169b31e..bde8da8fe7 100644 --- a/scripts/qemu.py +++ b/scripts/qemu.py @@ -13,7 +13,6 @@ # import errno -import string import os import sys import subprocess @@ -195,14 +194,12 @@ class QEMUMachine(object): self._load_io_log() self._post_shutdown() - underscore_to_dash = string.maketrans('_', '-') - def qmp(self, cmd, conv_keys=True, **args): '''Invoke a QMP command and return the response dict''' qmp_args = dict() for key, value in args.iteritems(): if conv_keys: - qmp_args[key.translate(self.underscore_to_dash)] = value + qmp_args[key.replace('_', '-')] = value else: qmp_args[key] = value -- 2.13.5