Hi, This series seems to have some coding style problems. See output below for more information:
Subject: [Qemu-devel] [PULL 00/11] Ide patches Message-id: 20170916010330.10435-1-js...@redhat.com Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' bc6172dc94 AHCI: remove DPRINTF macro 2ea9b926e3 AHCI: pretty-print FIS to buffer instead of stderr d23d77942b AHCI: Rework IRQ constants c3e3883d53 AHCI: Replace DPRINTF with trace-events a3f8dc5d3c IDE: replace DEBUG_AIO with trace events 3c992d8a98 ATAPI: Replace DEBUG_IDE_ATAPI with tracing events 3beaa3f939 IDE: add tracing for data ports 1994e49cc7 IDE: Add register hints to tracing a446948ea3 IDE: replace DEBUG_IDE with tracing system 8d2b13d3da hw/ide/microdrive: Mark the dscm1xxxx device with user_creatable = false 9bc5607864 ide: ahci: unparent children buses before freeing their memory === OUTPUT BEGIN === Checking PATCH 1/11: ide: ahci: unparent children buses before freeing their memory... Checking PATCH 2/11: hw/ide/microdrive: Mark the dscm1xxxx device with user_creatable = false... Checking PATCH 3/11: IDE: replace DEBUG_IDE with tracing system... ERROR: spaces required around that '|' (ctx:VxV) #146: FILE: hw/ide/core.c:1197: + if (reg_num != 7 && (s->status & (BUSY_STAT|DRQ_STAT))) { ^ total: 1 errors, 0 warnings, 337 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 4/11: IDE: Add register hints to tracing... Checking PATCH 5/11: IDE: add tracing for data ports... Checking PATCH 6/11: ATAPI: Replace DEBUG_IDE_ATAPI with tracing events... Checking PATCH 7/11: IDE: replace DEBUG_AIO with trace events... Checking PATCH 8/11: AHCI: Replace DPRINTF with trace-events... ERROR: Hex numbers must be prefixed with '0x' #548: FILE: hw/ide/trace-events:91: +handle_reg_h2d_fis_pmp(void *s, int port, char b0, char b1, char b2) "ahci(%p)[%d]: Port Multiplier not supported, FIS: 0x%02x-%02x-%02x" ERROR: Hex numbers must be prefixed with '0x' #549: FILE: hw/ide/trace-events:92: +handle_reg_h2d_fis_res(void *s, int port, char b0, char b1, char b2) "ahci(%p)[%d]: Reserved flags set in H2D Register FIS, FIS: 0x%02x-%02x-%02x" ERROR: Hex numbers must be prefixed with '0x' #555: FILE: hw/ide/trace-events:98: +handle_cmd_unhandled_fis(void *s, int port, uint8_t b0, uint8_t b1, uint8_t b2) "ahci(%p)[%d]: unhandled FIS type. cmd_fis: 0x%02x-%02x-%02x" total: 3 errors, 0 warnings, 496 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 9/11: AHCI: Rework IRQ constants... Checking PATCH 10/11: AHCI: pretty-print FIS to buffer instead of stderr... WARNING: line over 80 characters #60: FILE: hw/ide/ahci.c:1206: + char *pretty_fis = ahci_pretty_buffer_fis(ide_state->io_buffer, 0x10); total: 0 errors, 1 warnings, 60 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 11/11: AHCI: remove DPRINTF macro... === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@freelists.org