On Mon, 09/18 08:44, Kevin Wolf wrote: > > > > > + self._qemu_full_args = (self._wrapper + [self._binary] + > > > > > + self._base_args() + self._args) > > > > > > > > The parentheses seem superfluous. With those removed: > > > > > > > > Reviewed-by: Fam Zheng <f...@redhat.com> > > > > > > Congratulations, with this advice you just killed all Python-based > > > qemu-iotests and filled up my inbox with CI failure messages. :-) > > > > Oops. Why doesn't python understand such multi line expressions > > impllied by "+" just like in "[,]"? > > To be honest, I didn't know that either until now. But apparently the > different kinds of brackets (including those around function arguments) > are the only things that allow multiline expressions in Python.
Yes, and now I read that PEP recommends using brackets for multilines compared to backslashes. I was totally wrong with this advice. Fam
