On 18.09.2017 17:59, David Hildenbrand wrote: > No need to pass kvm_run. > > Signed-off-by: David Hildenbrand <da...@redhat.com> > --- > target/s390x/kvm.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/target/s390x/kvm.c b/target/s390x/kvm.c > index 14f864697d..da3f7e9895 100644 > --- a/target/s390x/kvm.c > +++ b/target/s390x/kvm.c > @@ -1852,7 +1852,7 @@ static int sigp_set_architecture(S390CPU *cpu, uint32_t > param, > return SIGP_CC_STATUS_STORED; > } > > -static int handle_sigp(S390CPU *cpu, struct kvm_run *run, uint8_t ipa1) > +static int handle_sigp(S390CPU *cpu, uint32_t ipb, uint8_t ipa1)
Maybe order the parameters alphabetically now? I.e. first ipa, then ipb? Anyway, feel free to add my: Reviewed-by: Thomas Huth <th...@redhat.com>