On 09/25/2017 05:09 PM, Alistair Francis wrote:
> diff --git a/target/cris/translate.c b/target/cris/translate.c
> index 38a999e6f1..8847005984 100644
> --- a/target/cris/translate.c
> +++ b/target/cris/translate.c
> @@ -138,7 +138,7 @@ typedef struct DisasContext {
>
> static void gen_BUG(DisasContext *dc, const char *file, int line)
> {
> - fprintf(stderr, "BUG: pc=%x %s %d\n", dc->pc, file, line);
> + error_report("BUG: pc=%x %s %d", dc->pc, file, line);
> if (qemu_log_separate()) {
> qemu_log("BUG: pc=%x %s %d\n", dc->pc, file, line);
> }
Eh, no, this should simply use qemu_log.
> diff --git a/target/ppc/translate.c b/target/ppc/translate.c
> index 606b605ba0..a3da22580e 100644
> --- a/target/ppc/translate.c
> +++ b/target/ppc/translate.c
> @@ -3943,8 +3943,8 @@ static inline void gen_op_mfspr(DisasContext *ctx)
> * allowing userland application to read the PVR
> */
> if (sprn != SPR_PVR) {
> - fprintf(stderr, "Trying to read privileged spr %d (0x%03x)
> at "
> - TARGET_FMT_lx "\n", sprn, sprn, ctx->nip - 4);
> + error_report("Trying to read privileged spr %d (0x%03x) at "
> + TARGET_FMT_lx "", sprn, sprn, ctx->nip - 4);
> if (qemu_log_separate()) {
> qemu_log("Trying to read privileged spr %d (0x%03x) at "
> TARGET_FMT_lx "\n", sprn, sprn, ctx->nip - 4);
Likewise. And all the others.
Perhaps we should kill qemu_log_separate as a bad idea?
> diff --git a/target/sh4/translate.c b/target/sh4/translate.c
> index 10191073b2..9f95410e53 100644
> --- a/target/sh4/translate.c
> +++ b/target/sh4/translate.c
> @@ -438,7 +438,7 @@ static void _decode_opc(DisasContext * ctx)
> }
>
> #if 0
> - fprintf(stderr, "Translating opcode 0x%04x\n", ctx->opcode);
> + error_report("Translating opcode 0x%04x", ctx->opcode);
> #endif
qemu_log.
>
> switch (ctx->opcode) {
> @@ -1799,7 +1799,7 @@ static void _decode_opc(DisasContext * ctx)
> break;
> }
> #if 0
> - fprintf(stderr, "unknown instruction 0x%04x at pc 0x%08x\n",
> + error_report("unknown instruction 0x%04x at pc 0x%08x",
> ctx->opcode, ctx->pc);
> fflush(stderr);
> #endif
qemu_log_mask(LOG_UNIMP, ...)
> @@ -1940,7 +1940,7 @@ void gen_intermediate_code(CPUState *cs,
> TranslationBlock *tb)
> disas_uc32_insn(env, dc);
>
> if (num_temps) {
> - fprintf(stderr, "Internal resource leak before %08x\n", dc->pc);
> + error_report("Internal resource leak before %08x", dc->pc);
> num_temps = 0;
> }
>
>
qemu_log.
r~
