On 26.09.2017 18:36, Alistair Francis wrote:
> On Tue, Sep 26, 2017 at 8:51 AM, Thomas Huth <th...@redhat.com> wrote:
>> The device uses serial_hds in its realize function and thus can't be
>> used twice. Apart from that, the comma in its name makes it quite hard
>> to use for the user anyway, since a comma is normally used to separate
>> the device name from its properties when using the "-device" parameter
>> or the "device_add" HMP command.
> 
> Is it worth changing the name now then as well?

Not sure, was there a reason for this name? E.g. is it used in a device
tree somewhere somehow? Anyway, with user_creatable = false, I think it
is not so urgent anymore to change it.

>> Signed-off-by: Thomas Huth <th...@redhat.com>
> 
> Reviewed-by: Alistair Francis <alistair.fran...@xilinx.com>

Thanks!

 Thomas

Reply via email to