On Wed, 09/27 10:03, Eduardo Habkost wrote: > @@ -51,7 +54,6 @@ class QEMUMonitorProtocol(object): > """ > self.__events = [] > self.__address = address > - self._debug = debug
Should you also drop the debug parameter from the method? > self.__sock = self.__get_sock() > self.__sockfile = None > if server: > @@ -83,8 +85,7 @@ class QEMUMonitorProtocol(object): > return > resp = json.loads(data) > if 'event' in resp: > - if self._debug: > - print >>sys.stderr, "QMP:<<< %s" % resp > + self.logger.debug("<<< %s", resp) > self.__events.append(resp) > if not only_event: > continue > @@ -164,8 +165,7 @@ class QEMUMonitorProtocol(object): > @return QMP response as a Python dict or None if the connection has > been closed > """ > - if self._debug: > - print >>sys.stderr, "QMP:>>> %s" % qmp_cmd > + self.logger.debug("<<< %s", qmp_cmd) This should be ">>> %s".