Dne 27.9.2017 v 15:03 Eduardo Habkost napsal(a): > Just setting level=DEBUG when debug is enabled is not enough: we > need to set up a log handler if we want debug messages generated > using logging.getLogger(...).debug() to be printed. > > This was not a problem before because logging.debug() calls > logging.basicConfig() implicitly, but it's safer to not rely on > that. > > Cc: "Alex Bennée" <alex.ben...@linaro.org> > Cc: Fam Zheng <f...@redhat.com> > Cc: "Philippe Mathieu-Daudé" <f4...@amsat.org> > Signed-off-by: Eduardo Habkost <ehabk...@redhat.com> > --- > tests/vm/basevm.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py > index 3c863bc237..686d88decf 100755 > --- a/tests/vm/basevm.py > +++ b/tests/vm/basevm.py > @@ -227,8 +227,8 @@ def main(vmcls): > if not argv and not args.build_qemu and not args.build_image: > print "Nothing to do?" > return 1 > - if args.debug: > - logging.getLogger().setLevel(logging.DEBUG) > + logging.basicConfig(level=(logging.DEBUG if args.debug > + else logging.WARN)) > vm = vmcls(debug=args.debug, vcpus=args.jobs) > if args.build_image: > if os.path.exists(args.image) and not args.force: >
Reviewed-by: Lukáš Doktor <ldok...@redhat.com>
signature.asc
Description: OpenPGP digital signature
