On 10/05/2017 10:50 AM, Daniel P. Berrange wrote: > The tcp_chr_free_connection & tcp_chr_disconnect methods both > skip all of their cleanup work unless the 's->connected' flag > is set. This flag is set when the incoming client connection > is ready to use. Crucially this is *after* the TLS handshake > has been completed. So if the TLS handshake fails and we try > to cleanup the failed client, all the cleanup is skipped as > 's->connected' is still false. > > The only important thing that should be skipped in this case > is sending of the CHR_EVENT_CLOSED, because we never got as > far as sending the corresponding CHR_EVENT_OPENED. Every other > bit of cleanup can be robust against being called even when > s->connected is false. > > Signed-off-by: Daniel P. Berrange <berra...@redhat.com> > --- > > Changed in v2: > > - Remove conditional checks for NULL (Marc-André) > - Don't use camelCase variable name (Marc-André)
Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
