On 10/10/2017 07:20 AM, Cornelia Huck wrote:
>> The last two function look similar enough that you could merge the
>> functions, e.g.:
>>
>> void cpu_inject_ext_pending_bit(S390CPU *cpu, int bit)
>> {
>> CPUS390XState *env = &cpu->env;
>>
>> env->pending_int |= bit;
>> cpu_interrupt(CPU(cpu), CPU_INTERRUPT_HARD);
>> }
>>
>> ?
>>
>> Apart from that, the patch looks fine to me.
>>
>> Thomas
> FWIW, I'd prefer to keep these as separate functions.
Certainly. In a later patch they diverge much more than would be easily
separated as Thomas suggests.
r~
