On Tue, Oct 10, 2017 at 08:15:37PM +0200, Juan Quintela wrote:
[...]
> diff --git a/migration/page_cache.h b/migration/page_cache.h
> index 931868b857..4596496416 100644
> --- a/migration/page_cache.h
> +++ b/migration/page_cache.h
> @@ -24,12 +24,11 @@ typedef struct PageCache PageCache;
> *
> * Returns new allocated cache or NULL on error
> *
> - * @cache pointer to the PageCache struct
> - * @num_pages: cache maximal number of cached pages
> + * @cache_size: cache size in byets
^^^^^
(typo)
> * @page_size: cache page size
> + * @errp: set *errp if the check failed, with reason
> */
> -PageCache *cache_init(size_t num_pages, size_t page_size);
> -
> +PageCache *cache_init(int64_t cache_size, size_t page_size, Error **errp);
Besides:
Reviewed-by: Peter Xu <pet...@redhat.com>
--
Peter Xu
