On Thu, 12 Oct 2017 17:20:51 +0200 Greg Kurz <gr...@kaod.org> wrote: > On Thu, 12 Oct 2017 16:58:39 +0200 > Igor Mammedov <imamm...@redhat.com> wrote: > > > On Thu, 12 Oct 2017 15:10:30 +0200 > > Greg Kurz <gr...@kaod.org> wrote: > > > > > On Tue, 10 Oct 2017 09:29:46 +0200 > > > Greg Kurz <gr...@kaod.org> wrote: > > > > > > > On Mon, 9 Oct 2017 21:51:00 +0200 > > > > Igor Mammedov <imamm...@redhat.com> wrote: > > > > > > > > > spapr core type definition doesn't have any fields that > > > > > require it to be defined at runtime. So replace code > > > > > that fills in TypeInfo at runtime with static TypeInfo > > > > > array that does the same at complie time. > > > > > > > > > > Signed-off-by: Igor Mammedov <imamm...@redhat.com> > > > > > --- > > > > > v2: > > > > > - fix rebase conflict: add newly added power9_v2 core > > > > > --- > > > > > > > > Reviewed-by: Greg Kurz <gr...@kaod.org> > > > > > > > > > > Oops, this patch causes a regression when you try to pass a sPAPR core to > > > a non-pseries machine. > > > > > > Without this patch: > > > > > > $ ppc64-softmmu/qemu-system-ppc64 -M none -device host-spapr-cpu-core > > > qemu-system-ppc64: -device host-spapr-cpu-core: > > > 'host-spapr-cpu-core' is not a valid device model name > > > > > > With this patch: > > > > > > $ ppc64-softmmu/qemu-system-ppc64 -M none -device host-spapr-cpu-core > > > ** > > > ERROR:qom/object.c:217:object_type_get_instance_size: > > > assertion failed: (type != NULL) > > > Aborted > > there shouldn't be type host-spapr-cpu-core with this patch since you don't > > have -enable-kvm on CLI > > maybe you are talking about > > [PATCH v2 15/24] ppc: spapr: register 'host' core type along with the > > rest of core types > > > > Oops you're right, I replied to the wrong mail... of course, I meant the > following commit in David's staging tree: > > https://github.com/dgibson/qemu/commit/c18165144076cef0c17206f5231cf9787c944037
fixed by: [PATCH v2 14/24] fixup! ppc: spapr: use cpu type name directly also I've stumbled upon another issue, fixup also posted: [PATCH v2 18/24] fixup! ppc: spapr: use generic cpu_model parsing fixup well localized and didn't cause conflicts so there is no need to respin series
