On 10/12/2017 05:27 PM, Eric Blake wrote:
> On 10/12/2017 04:53 AM, Vladimir Sementsov-Ogievskiy wrote:
>> Send qiov via qio_channel_writev_all instead of calling nbd_write twice
>> with a cork.
>>
>> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com>
>> ---
>> nbd/server.c | 50 ++++++++++++++++++++++++--------------------------
>> 1 file changed, 24 insertions(+), 26 deletions(-)
>>
>
>> @@ -1203,36 +1220,17 @@ static int nbd_co_send_simple_reply(NBDClient
>> *client,
>> size_t len,
>> Error **errp)
>> {
>> - NBDSimpleReply simple_reply;
>> - int ret;
>> -
>> - g_assert(qemu_in_coroutine());
>> + NBDSimpleReply reply;
>
> Why the rename from simple_reply to reply?
>
>> + struct iovec iov[] = {
>> + {.iov_base = &reply, .iov_len = sizeof(reply)},
>
> I guess it made this line shorter. But we could reduce some churn by
> naming it 'reply' in the first place, back in earlier patches. At the
> same time, I'm not going to bother if there's not a reason to respin the
> series (or at least the first half).Answering myself - you couldn't use the name 'reply' until 5/13 removed it as a parameter name, even though you introduced the name 'simple_reply' in 4/13. Okay, the rename is fine here. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
