On 10/18/2017 12:48 AM, Gerd Hoffmann wrote:
>   Hi,
> 
>> +if [ "$capstone_internal" = "yes" ]; then
>> +  echo "config-host.h: subdir-capstone" >> $config_host_mak
>> +fi
> 
> I think this isn't going to work correctly.  In case both capstone and
> dtc are used we need a single line with the dependencies, i.e.
> 
>   config-host.h: subdir-dtc subdir-capstone

Make allows the composition of dependencies, as in:

a: b
a: c

It works as long as at most one a: line contains the rule for building
a, and all the other lines just add dependencies.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to