On 20.10.2017 13:58, David Hildenbrand wrote: > For now, e.g. host-s390-cpu wasn't exposed to the user. cpu-add, -cpu > and the CPU model qmp interfaces didn't care about the actual type, > as that information was hidden. > > This changed with CPU hotplug via device_add. Now the type is visible to > the user. Before we get that supported in a stable version, this is our > last chance to change it. > > So change it form "s390-cpu" to "s390x-cpu", to match the architecture > name. Example names are then e.g. z14-s390x-cpu or qemu-s390x-cpu.
Basically fine for me ... but just to be sure: Did you test whether migration still works fine from older versions to a version that contains this patch? Thomas