在 10/25/2017 2:51 PM, Wang Guang 写道: > replication_child_perm request write > permissions for all child which will lead bdrv_check_perm fail. > replication_child_perm() should request write > permissions only if it is writable itself. > > Signed-off-by: Wang Guang <wang.guan...@zte.com.cn> > Signed-off-by: Wang Yong <wang.yong...@zte.com.cn>
Thanks, this patch fixs the problem in http://lists.nongnu.org/archive/html/qemu-devel/2017-08/msg03358.html. Reviewed-by: Xie Changlong <xiechangl...@cmss.chinamobile.com> > --- > block/replication.c | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/block/replication.c b/block/replication.c > index 3a4e682..1c95d67 100644 > --- a/block/replication.c > +++ b/block/replication.c > @@ -161,10 +161,13 @@ static void replication_child_perm(BlockDriverState > *bs, BdrvChild *c, > uint64_t perm, uint64_t shared, > uint64_t *nperm, uint64_t *nshared) > { > - *nperm = *nshared = BLK_PERM_CONSISTENT_READ \ > - | BLK_PERM_WRITE \ > - | BLK_PERM_WRITE_UNCHANGED; > - > + *nperm = BLK_PERM_CONSISTENT_READ; > + if ((bs->open_flags & (BDRV_O_INACTIVE | BDRV_O_RDWR)) == BDRV_O_RDWR) { > + *nperm |= BLK_PERM_WRITE; > + } > + *nshared = BLK_PERM_CONSISTENT_READ \ > + | BLK_PERM_WRITE \ > + | BLK_PERM_WRITE_UNCHANGED; > return; > } > > -- Thanks -Xie
