On Thu, Nov 9, 2017 at 3:09 AM, Peter Maydell <peter.mayd...@linaro.org> wrote: > On 8 November 2017 at 15:10, Alistair Francis > <alistair.fran...@xilinx.com> wrote: >> When cross compiling QEMU for Windows we need to specify the cross >> version of ranlib to avoid build errors when building capstone. This >> patch ensures we use the same cross prefix on ranlib as other toolchain >> components. >> >> This patch fixes this build error when building on RHEL (or Fedora) with >> MinGW: >> /scratch/jenkins_tmp/workspace/QEMU-BuildAll/label/ssw_rhel7/target/windows/build-windows/capstone/capstone.lib: >> error adding symbols: Archive has no index; run ranlib to add one >> collect2: error: ld returned 1 exit status >> make: *** [qemu-io.exe] Error 1 >> >> Signed-off-by: Alistair Francis <alistair.fran...@xilinx.com> >> Suggested-by: Peter Maydell <peter.mayd...@linaro.org> >> Reviewed-by: Philippe Mathieu-Daud <f4...@amsat.org> >> Tested-by: Philippe Mathieu-Daud <f4...@amsat.org> > > Something in your patch handling workflow seems to be > breaking non-ASCII characters, and it has dropped the > last character in Philippe's surname. It would be good > if you could look into fixing this -- we have quite a > few contributors whose names are not representable > purely in ASCII.
I think it's the way that I copy lines into the patches. I'll be sure to make sure I get all the characters next time. Thanks for pointing it out. Alistair > > thanks > -- PMM
