On 11/10/2017 04:13 PM, Max Reitz wrote:
> Instead of converting all "backing": null instances into "backing": "",
> handle a null value directly in bdrv_open_inherit().
>
> This enables explicitly null backing links for json:{} filenames.
>
> Signed-off-by: Max Reitz <mre...@redhat.com>
> ---
> block.c | 2 +-
> blockdev.c | 14 --------------
> tests/qemu-iotests/089 | 20 ++++++++++++++++++++
> tests/qemu-iotests/089.out | 8 ++++++++
> 4 files changed, 29 insertions(+), 15 deletions(-)
> > @@ -3899,19 +3898,6 @@ void qmp_blockdev_add(BlockdevOptions *options, Error > **errp) > > qdict_flatten(qdict); > > - /* > - * Rewrite "backing": null to "backing": "" > - * TODO Rewrite "" to null instead, and perhaps not even here > - */ Nice that the TODO told you what to do :) Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
