Richard Henderson <richard.hender...@linaro.org> writes: > This patch set depends on v3 of native-vector-registers; > for ease of review the whole tree is at > > git://github.com/rth7680/qemu.git tgt-arm-cplx > > I have successfully tested all insns for AArch64 via RISU. > I have successfully tested everything but VCMLA for AArch32. > > The insn that doesn't match up is > > fef3c848 vcmla.f32 q14, <illegal reg q1.5>, d8[0], #270 > > for which FoundationModel is *not* signalling illegal insn. > I'm not really sure what it is doing -- perhaps treating the > insn as a coprocessor 8 nop? I'll have to investigate further. > > In the meantime, it's surely time for a round 1 review.
OK I'm done with round 1 review, I skipped past the later complex instructions as I don't have access to the 8.3 ARM ARM yet (although the instructions are in the ASL HTML dumps). > > > r~ > > > Richard Henderson (12): > HACK: use objdump disas > target/arm: Add ARM_FEATURE_V8_1_SIMD > target/arm: Decode aa64 armv8.1 scalar three same extra > target/arm: Decode aa64 armv8.1 three same extra > target/arm: Decode aa64 armv8.1 scalar/vector x indexed element > target/arm: Decode aa32 armv8.1 three same > target/arm: Decode aa32 armv8.1 two reg and a scalar > target/arm: Add ARM_FEATURE_V8_FCMA > target/arm: Decode aa64 armv8.3 fcadd > target/arm: Decode aa64 armv8.3 fcmla > target/arm: Decode aa32 armv8.3 3-same > target/arm: Decode aa32 armv8.3 2-reg-index > > target/arm/cpu.h | 2 + > target/arm/helper.h | 26 ++++ > disas.c | 2 +- > linux-user/elfload.c | 10 ++ > target/arm/advsimd_helper.c | 331 +++++++++++++++++++++++++++++++++++++++++ > target/arm/cpu.c | 2 + > target/arm/cpu64.c | 2 + > target/arm/translate-a64.c | 350 > +++++++++++++++++++++++++++++++++++++++----- > target/arm/translate.c | 241 +++++++++++++++++++++++++++--- > target/arm/Makefile.objs | 2 +- > 10 files changed, 912 insertions(+), 56 deletions(-) > create mode 100644 target/arm/advsimd_helper.c -- Alex Bennée