On Wed, Nov 15, 2017 at 04:56:13PM -0500, John Snow wrote: > > > On 11/15/2017 04:54 PM, Kashyap Chamarthy wrote: > > On Wed, Nov 15, 2017 at 02:15:57PM -0500, John Snow wrote:
[...] > >> is it covered sufficiently in live-block-operations.rst ? > > > > I looked in there[2] too. Short answer: no. Long: In the "Live disk > > synchronization — drive-mirror and blockdev-mirror" section, I simply > > seemed to declare: > > > > "Issuing the command ``block-job-cancel`` after it emits the event > > ``BLOCK_JOB_CANCELLED``" > > > > As if that's the *only* event it emits, which is clearly not the case. > > So while at it, wonder if should I also update it > > ('live-block-operations.rst') too. > > > > It's an interesting gotcha that I wasn't really acutely aware of myself, > so having it in the doc format for API programmers who aren't > necessarily digging through our source sounds like a pleasant courtesy. Indeed, will do. (Just for my own clarity, did you imply: don't update it in block-core.json? FWIW, my first instinct is to check the QAPI documentation for such things, that's why I wrote there first :-)) Thanks for looking. [...] -- /kashyap