On 11/16/2017 06:05 PM, David Hildenbrand wrote:
> Looks like the last fix + cleanup introduced another bug. (for now Linux
> guests don't seem to care) - we store the crs into ars.
>
> Fixes: 947a38bd6f13 ("s390x/kvm: fix and cleanup storing CPU status")
> Signed-off-by: David Hildenbrand <da...@redhat.com>
Reviewed-by: Christian Borntraeger <borntrae...@de.ibm.com>
> ---
> target/s390x/helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/s390x/helper.c b/target/s390x/helper.c
> index f78983dd6a..246ba20f0d 100644
> --- a/target/s390x/helper.c
> +++ b/target/s390x/helper.c
> @@ -279,7 +279,7 @@ int s390_store_status(S390CPU *cpu, hwaddr addr, bool
> store_arch)
> sa->ars[i] = cpu_to_be32(cpu->env.aregs[i]);
> }
> for (i = 0; i < 16; ++i) {
> - sa->ars[i] = cpu_to_be64(cpu->env.cregs[i]);
> + sa->crs[i] = cpu_to_be64(cpu->env.cregs[i]);
> }
>
> cpu_physical_memory_unmap(sa, len, 1, len);
>
