Hi, This series seems to have some coding style problems. See output below for more information:
Subject: [Qemu-devel] [PATCH 00/24] RfC: rework display initialization Type: series Message-id: 20171117103046.15943-1-kra...@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20171117103046.15943-1-kra...@redhat.com -> patchew/20171117103046.15943-1-kra...@redhat.com Switched to a new branch 'test' 8ad8a3a49f build: opengl should not need X11 6f326898be curses: build as module f28cbe0c71 gtk: build as module b40a8ab831 sdl: build as module b2ff35530c console: add ui module loading support 608541ecf1 console: add and use qemu_display_find_default c9ea5c8f98 egl-headless: hook up to display registry e4027611d6 curses: hook up to display registry e80738a2e4 cocoa: hook up to display registry d4e140bc0d sdl: hook up to display registry 527146bbaf console: add qemu display registry, add gtk 33878ca938 vl: drop request_opengl variable d788c7b02b vl: drop display_type variable 79864bf5a8 vl: drop full_screen variable 86920e800f cocoa: use DisplayOptions c452a6e243 curses: use DisplayOptions 2c82950f1c egl-headless: use DisplayOptions b144a95d3d vl: drop no_quit variable 640b59b752 sdl: use DisplayOptions 2a3081d35b gtk: add and use DisplayOptions + DisplayGTK 756824d0cf vl: rename DisplayType to LegacyDisplayType a7a6f0c0b2 sdl: use ctrl-alt-g as grab hotkey e4dde3438f sdl: remove -alt-grab and -ctrl-grab support 1c32dd624f sdl: remove -no-frame support === OUTPUT BEGIN === Checking PATCH 1/24: sdl: remove -no-frame support... Checking PATCH 2/24: sdl: remove -alt-grab and -ctrl-grab support... ERROR: space prohibited after that '&' (ctx:WxW) #48: FILE: ui/sdl.c:554: + mod_state = (SDL_GetModState() & gui_grab_code) == gui_grab_code; ^ ERROR: space prohibited after that '&' (ctx:WxW) #96: FILE: ui/sdl2.c:333: + mod_state = (SDL_GetModState() & gui_grab_code) == gui_grab_code; ^ total: 2 errors, 0 warnings, 135 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 3/24: sdl: use ctrl-alt-g as grab hotkey... Checking PATCH 4/24: vl: rename DisplayType to LegacyDisplayType... Checking PATCH 5/24: gtk: add and use DisplayOptions + DisplayGTK... Checking PATCH 6/24: sdl: use DisplayOptions... Checking PATCH 7/24: vl: drop no_quit variable... Checking PATCH 8/24: egl-headless: use DisplayOptions... Checking PATCH 9/24: curses: use DisplayOptions... Checking PATCH 10/24: cocoa: use DisplayOptions... Checking PATCH 11/24: vl: drop full_screen variable... Checking PATCH 12/24: vl: drop display_type variable... Checking PATCH 13/24: vl: drop request_opengl variable... Checking PATCH 14/24: console: add qemu display registry, add gtk... Checking PATCH 15/24: sdl: hook up to display registry... Checking PATCH 16/24: cocoa: hook up to display registry... Checking PATCH 17/24: curses: hook up to display registry... Checking PATCH 18/24: egl-headless: hook up to display registry... Checking PATCH 19/24: console: add and use qemu_display_find_default... Checking PATCH 20/24: console: add ui module loading support... Checking PATCH 21/24: sdl: build as module... Checking PATCH 22/24: gtk: build as module... Checking PATCH 23/24: curses: build as module... Checking PATCH 24/24: build: opengl should not need X11... === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@freelists.org