Revisiting an old series: On 06/28/2017 07:05 AM, Vladimir Sementsov-Ogievskiy wrote: > Hi all! > > There is a new update of qcow2-bitmap series - v22. > > web: > https://src.openvz.org/users/vsementsov/repos/qemu/browse?at=qcow2-bitmap-v22 > git: https://src.openvz.org/scm/~vsementsov/qemu.git (tag qcow2-bitmap-v22) > > v22: > > Rebase on master, so changes, mostly related to new dirty bitmaps mutex: >
> qcow2: add persistent dirty bitmaps support > > block.c | 65 +- > block/Makefile.objs | 2 +- > block/dirty-bitmap.c | 154 ++++- > block/io.c | 8 + > block/qcow2-bitmap.c | 1481 > ++++++++++++++++++++++++++++++++++++++++++ > block/qcow2-refcount.c | 59 +- > block/qcow2.c | 155 ++++- > block/qcow2.h | 43 ++ > blockdev.c | 73 ++- > docs/interop/qcow2.txt | 8 +- > include/block/block.h | 3 + > include/block/block_int.h | 14 + > include/block/dirty-bitmap.h | 22 +- > include/qemu/hbitmap.h | 49 +- > qapi/block-core.json | 42 +- > tests/Makefile.include | 2 +- > tests/qemu-iotests/165 | 105 +++ > tests/qemu-iotests/165.out | 5 + > tests/qemu-iotests/group | 1 + > tests/test-hbitmap.c | 19 + > util/hbitmap.c | 51 +- > 21 files changed, 2280 insertions(+), 81 deletions(-) Nothing in this series touched qemu-img. At the very minimum, it would be nice if 'qemu-img info' were to display a summary of all bitmaps in the qcow2 file; the QMP type ImageInfoSpecificQCow2 should be updated to mention this information, and qemu-img updated to output it. Being able to create and remove persistent bitmaps from an at-rest qcow2 file without having to fire up qemu to issue QMP commands to do so would also be nice. It's a bit late for getting this request into 2.12, but had it been available, it would make my work at testing that 'qemu-img commit' doesn't corrupt persistent bitmaps. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
