On 11/16/2017 11:38 AM, Cleber Rosa wrote: > Another legacy variable that did not convince me it has any > purpose whatsoever. > > Signed-off-by: Cleber Rosa <cr...@redhat.com> > ---
> +++ b/tests/qemu-iotests/001 > @@ -23,7 +23,6 @@ > seq=`basename $0` > echo "QA output created by $seq" > > -here=`pwd` Good riddance. And in the majority of the tests, it was a needless fork(), compared to my preference (which is also guaranteed by POSIX and by /bin/bash): > +++ b/tests/qemu-iotests/176 > @@ -27,7 +27,6 @@ > seq="$(basename $0)" > echo "QA output created by $seq" > > -here="$PWD" since $PWD and `pwd` should always produce the same thing, if we even had a reason to use it. ;) Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature