On Tue, Nov 21, 2017 at 10:04 AM, Peter Maydell <peter.mayd...@linaro.org> wrote: > On 6 November 2017 at 15:47, Andrey Smirnov <andrew.smir...@gmail.com> wrote: >> Cc: Peter Maydell <peter.mayd...@linaro.org> >> Cc: Jason Wang <jasow...@redhat.com> >> Cc: Philippe Mathieu-Daudé <f4...@amsat.org> >> Cc: qemu-devel@nongnu.org >> Cc: qemu-...@nongnu.org >> Cc: yurov...@gmail.com >> Signed-off-by: Andrey Smirnov <andrew.smir...@gmail.com> >> --- >> hw/sd/sdhci.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c >> index f561cc44e3..53e5e011a7 100644 >> --- a/hw/sd/sdhci.c >> +++ b/hw/sd/sdhci.c >> @@ -1139,6 +1139,9 @@ sdhci_write(void *opaque, hwaddr offset, uint64_t val, >> unsigned size) >> s->admasysaddr = (s->admasysaddr & (0x00000000FFFFFFFFULL | >> ((uint64_t)mask << 32))) | ((uint64_t)value << 32); >> break; >> + case SDHC_ACMD12ERRSTS: >> + MASKED_WRITE(s->acmd12errsts, mask, value); >> + break; >> case SDHC_FEAER: >> s->acmd12errsts |= value; >> s->errintsts |= (value >> 16) & s->errintstsen; >> -- >> 2.13.6 > > Is this part of the stock SDHCI spec that we just forgot to implement?
Yes it is. I don't know if missing that code critical for anything, but since the rest of the plumbing is there I thought that we may as well implement it. Thanks, Andrey Smirnov
