On 11/22/2017 04:19 AM, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com> > --- > nbd/server.c | 74 > +++++++++++++++++++++++++++++++++++++----------------------- > 1 file changed, 46 insertions(+), 28 deletions(-) >
> +/* nbd_opt_invalid > + * Drop reminded option data and reply with NBD_REP_ERR_INVALID s/reminded/the remainder of/ In fact, if we generalize this just a bit more, and let the caller choose whether to use NBD_REP_ERR_INVALID or NBD_REP_ERR_TLS_REQD or NBD_REP_ERR_UNSUP, then we can merge this functionality directly into nbd_opt_drop() instead of adding another function. I guess I'll have to merge that into the counter-proposal I have in mind (but at this point, the counter-proposal won't be posted any sooner than 2.11-rc3, in part because I'm almost on my Thanksgiving vacation). -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
