On Thu, 23 Nov 2017 19:01:46 +0100 Christian Borntraeger <borntrae...@de.ibm.com> wrote:
> On 11/23/2017 06:44 PM, Auger Eric wrote: > > Hi Cornelia, Peter, > > > > On 23/11/17 18:14, Cornelia Huck wrote: > >> On Thu, 23 Nov 2017 17:01:32 +0000 > >> Peter Maydell <peter.mayd...@linaro.org> wrote: > >> > >>> On 23 November 2017 at 16:05, Auger Eric <eric.au...@redhat.com> wrote: > >>>> When using update-linux-headers.sh I get suspicious errors at the end: > >>>> grep: /tmp/tmp.A5NjLtHOij/include/asm/kvm_virtio.h: No such file or > >>>> directory > >>>> sed: can't read /tmp/tmp.A5NjLtHOij/include/asm/kvm_virtio.h: No such > >>>> file or directory > >>>> > >>>> and include/standard-headers/asm-s390/virtio-ccw.h deletedch > >>>> > >>>> I would prefer having s390 people checking and testing that. > >>> > >>> I think the kvm_virtio.h problem should be fixed by > >>> http://patchwork.ozlabs.org/patch/838230/ > >>> which removes it from the set of headers the script imports. > >>> > >>> Cornelia/Christian -- any idea about the virtio-ccw.h issue ? > >>> > >>> thanks > >>> -- PMM > >> > >> I had that commit queued for post-2.11, but I can also send it for 2.11. > >> > >> The virtio-ccw.h one looks weird... if I run the script on my s390-next > >> branch against recent-ish Linux master, I just get the SPDX notice > >> update for virtio-ccw.h. > >> > > > > http://patchwork.ozlabs.org/patch/838230/ effectively fixes all issues: > > - no errors anymore and > > - no deletion of include/standard-headers/asm-s390/virtio-ccw.h anymore, > > which is consistent with include/standard-headers/asm-s390/virtio-ccw.h. > > > > I assume the vITS code is post 2.11? If not, we can certainly submit 3 or 4 > s390 patches (including 838230) for 2.11. > OTOH, we'll just have pain for any headers update until the first s390x set for post 2.11 has been merged, so I'll send a pull request with just that headers change.
