On 12/10/2017 06:19 PM, Samuel Thibault wrote: > Baum device bigger than 84 do not actually exist, some guest drivers > would be upset by such sizes. > > Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> > --- > chardev/baum.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) >
> @@ -239,6 +239,12 @@ static int baum_deferred_init(BaumChardev *baum)
> brlapi_perror("baum: brlapi__getDisplaySize");
> return 0;
> }
> + if (baum->y > 1) {
> + baum->y = 1;
> + }
> + if (baum->x > 84) {
> + baum->x = 84;
> + }
Is magic clamping desirable, or is it better to make it a hard error if
the user configured a size that is not possible?
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
