On Wed, Dec 22, 2010 at 08:27:17AM +0200, Michael S. Tsirkin wrote: > On Wed, Dec 22, 2010 at 12:13:43PM +0900, Isaku Yamahata wrote: > > Right now pcibus_get_dev_path() isn't migration save because > > bus number/secondary bus number are set by guest OS. > > So it can't be used reliably for qemu internal id. > > > > For 0.14 release, disable p2p bridge migration at the moment. > > Once pcibus_get_dev_path() is fixed, this patch should be reverted. > > It will be addressed for 0.15 release. > > > > Cc: "Michael S. Tsirkin" <m...@redhat.com> > > Cc: Alex Williamson <alex.william...@redhat.com> > > Cc: Blue Swirl <blauwir...@gmail.com> > > Signed-off-by: Isaku Yamahata <yamah...@valinux.co.jp> > > > Hmm, haven't looked into this deeply - can we do this in one place > when the bridge is created?
Unfortunately it's not easy. It requires revising register_device_unmigratable(). I have to admit this patch is ugly. This patch is temporal work around and should be reverted eventually. So I think it is better to address the original issue (allowing migration of p2p bridge) instead of addressing register_device_unmigratable(). thanks -- yamahata