* Igor Mammedov (imamm...@redhat.com) wrote:
> On Wed, 27 Dec 2017 14:19:03 +0100
> Igor Mammedov <imamm...@redhat.com> wrote:
>
> > On Mon, 18 Dec 2017 20:13:38 +0000
> > "Dr. David Alan Gilbert (git)" <dgilb...@redhat.com> wrote:
> >
> > > From: "Dr. David Alan Gilbert" <dgilb...@redhat.com>
> > >
> > > Compare the sections list that's just been generated, and if it's
> > > different from the old one regenerate the region list.
> > >
> > > Signed-off-by: Dr. David Alan Gilbert <dgilb...@redhat.com>
> > > ---
> [...]
> >
> > > + if (!dev->started) {
> > also why memmap is generated this early and not right before first use?
> > here we might generate memap but not actually use it.
> I retract question, as commit + follow up set_mem_table could happen before
> device is started. Having a comment here explaining it would be nice as
> the call flow is obvious.
Yes, and I think I've seen that. I'll add a comment.
Dave
>
> > > goto out;
> > > }
> > >
> >
> >
>
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
