On 12/08/2017 11:33 AM, Dr. David Alan Gilbert wrote: >> @@ -2223,7 +2224,7 @@ void hmp_nbd_server_add(Monitor *mon, const QDict >> *qdict) >> bool writable = qdict_get_try_bool(qdict, "writable", false); >> Error *local_err = NULL; >> >> - qmp_nbd_server_add(device, true, writable, &local_err); >> + qmp_nbd_server_add(device, false, NULL, true, writable, &local_err); > > I wont insist, but it would be nice if you wired up an optional > parameter on HMP as well.
Can be done as a followup patch; I'm not sure how many people are setting up NBD exports via HMP, and I'm also okay with just stating that the full power requires use of QMP. But I'll give such a followup patch a quick try, to see whether it is easy after all. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
