On 12/19/2017 02:45 AM, Peter Xu wrote: Grammar in the subject:
s/monitor dedicate/a dedicated monitor/ > Create one IOThread for the monitors, prepared to handle all the > input/output IOs using existing iothread framework. > > Signed-off-by: Peter Xu <pet...@redhat.com> > --- > monitor.c | 29 +++++++++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > > @@ -207,6 +208,11 @@ struct Monitor { > QTAILQ_ENTRY(Monitor) entry; > }; > > +/* Let's add monitor global variables to this struct. */ Is this comment a placeholder for future additions in later patches of the series? If so, a temporary TODO or FIXME might make it easier to track that this patch is part of a series; if not, you could delete the comment altogether. > +static struct { > + IOThread *mon_iothread; > +} mon_global; > + Up to you what to do about the comment; tweaking it (or leaving it unchanged) is not a semantic change, so I'm fine with: Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature