On 17 January 2018 at 19:15, Igor Mammedov <imamm...@redhat.com> wrote: > On Wed, 17 Jan 2018 16:12:09 +0000 > Peter Maydell <peter.mayd...@linaro.org> wrote: >> I like moving this from being an ifdef ladder into per-cpu >> code, but I don't think the definition belongs in target/$ARCH. >> It's part of the choice usermode makes about how to handle >> binaries it's loading, so it should go in linux-user/$ARCH/target_cpu.h. >> target/$ARCH should really be for things that are properties >> of the architecture. > That's used not only by linux-user but also reused by null-machine.c > to get access to a target specific cpu_class_by_name() callback.
That usage must want a different name, though, surely? For Arm the default CPU for linux-user is 'any' but that is usermode only and won't work for system emulation so null-machine.c will need to pick something else. thanks -- PMM
