On Tue, Nov 30, 2010 at 02:26:03PM +0100, Gerd Hoffmann wrote: > This patch tags all pci devices which belong to the piix3/4 chipsets as > not hotpluggable (Host bridge, ISA bridge, IDE controller, ACPI bridge). > > Signed-off-by: Gerd Hoffmann <kra...@redhat.com> > --- > hw/acpi_piix4.c | 2 ++ > hw/ide/piix.c | 2 ++ > hw/piix4.c | 1 + > hw/piix_pci.c | 2 ++ > 4 files changed, 7 insertions(+), 0 deletions(-) > > diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c > index 173d781..273097d 100644 > --- a/hw/acpi_piix4.c > +++ b/hw/acpi_piix4.c > @@ -428,6 +428,8 @@ static PCIDeviceInfo piix4_pm_info = { > .qdev.desc = "PM", > .qdev.size = sizeof(PIIX4PMState), > .qdev.vmsd = &vmstate_acpi, > + .qdev.no_user = 1, > + .no_hotplug = 1, > .init = piix4_pm_initfn, > .config_write = pm_write_config, > .qdev.props = (Property[]) { > diff --git a/hw/ide/piix.c b/hw/ide/piix.c > index 07483e8..173ba4b 100644 > --- a/hw/ide/piix.c > +++ b/hw/ide/piix.c > @@ -184,11 +184,13 @@ static PCIDeviceInfo piix_ide_info[] = { > .qdev.name = "piix3-ide", > .qdev.size = sizeof(PCIIDEState), > .qdev.no_user = 1, > + .no_hotplug = 1, > .init = pci_piix3_ide_initfn, > },{ > .qdev.name = "piix4-ide", > .qdev.size = sizeof(PCIIDEState), > .qdev.no_user = 1, > + .no_hotplug = 1, > .init = pci_piix4_ide_initfn, > },{ > /* end of list */ > diff --git a/hw/piix4.c b/hw/piix4.c > index 5489386..1678898 100644 > --- a/hw/piix4.c > +++ b/hw/piix4.c > @@ -113,6 +113,7 @@ static PCIDeviceInfo piix4_info[] = { > .qdev.desc = "ISA bridge", > .qdev.size = sizeof(PCIDevice), > .qdev.no_user = 1, > + .qdev.no_hotplug = 1, > .init = piix4_initfn, > },{ > /* end of list */
This one breaks the build for me. The below seems to help - but begs the question: was this tested? Thanks, diff --git a/hw/piix4.c b/hw/piix4.c index 1678898..00da049 100644 --- a/hw/piix4.c +++ b/hw/piix4.c @@ -113,7 +113,7 @@ static PCIDeviceInfo piix4_info[] = { .qdev.desc = "ISA bridge", .qdev.size = sizeof(PCIDevice), .qdev.no_user = 1, - .qdev.no_hotplug = 1, + .no_hotplug = 1, .init = piix4_initfn, },{ /* end of list */