* Stefan Hajnoczi <stefa...@linux.vnet.ibm.com> [2011-01-05 19:54:17]:
> On Tue, Jan 04, 2011 at 10:57:20AM +0530, Arun R Bharadwaj wrote:
> > +static void aio_thread(ThreadletWork *work)
> > +{
>
> aio_thread() is not a descriptive name here. This isn't the top-level
> thread function, just the work->func. Please choose something like
> handle_aiocb() or handle_work().
>
> > + pid_t pid;
> > + ssize_t ret = 0;
> > + struct qemu_paiocb *aiocb;
> > +
> > + pid = getpid();
> > + aiocb = container_of(work, struct qemu_paiocb, work);
> > + aiocb->active = 1;
>
> aiocb_mutex?
>
I'll take care of this.
-arun
