Perfect. Thanks Paolo. Will submit the Patch V2 with your requested changes today.
Justin > -----Original Message----- > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Thursday, January 18, 2018 12:16 AM > To: Justin Terry (VM) <jute...@microsoft.com> > Cc: qemu-devel@nongnu.org qemu-devel <qemu-devel@nongnu.org> > Subject: Re: [PATCH 0/4] Implements the Windows Hypervisor Platform > accelerator > > On 18/01/2018 00:41, Justin Terry (VM) wrote: > > > > Thanks for all the feedback. After talking with various members of the > > team around these scenarios I think its best we add the migration > > blockers for all of your comments unfortunately. The answers to your > > question are below: > > > > 1. For CPUID. The API has support for an "EXTENDED_VM_EXITS" of type > > WHvRunVpExitReasonX64Cpuid after a call to WHvRunVirtualProcessor. > > This will one day allow for the CPUID instruction to be resolved > > however it is not currently implemented in the platform. So for right > > now we will have to block on CPUID. > > > > 2. For dirty memory tracking. We currently don’t have support in the > > platform or API for this. I have added that to the feature backlog and > > will update QEMU as that gets implemented in the platform. > > However, VGA does indeed work with the current impl of log_sync. > > > > 3. Also, for XSAVE/RSTOR we again don’t have platform support for the > > required registers. I have added this to the feature platform backlog > > to gain access for that functionality as well. > > > > 4. This will be supported on Windows 10 hosts (I don’t have the > > insider build number yet) and it will require an Intel processor with > > VT-x and Unrestricted Guest support. Will update the qemu-devel list > > once we have an insider build that is public that has the platform > > bits. > > > > So, if your ok with it I will block on CPUID, Memory Tracking, and > > XSAVE/RSTOR functionality and send out the updated PR. > > Yes, thanks. Of course just one migration blocker is enough. Add a comment > like the above 1-3 bullet points above it. > > Thanks, > > Paolo