On 01/31/2018 08:48 AM, Markus Armbruster wrote: > System headers should be included with <...>, our own headers with > "...". Offenders tracked down with an ugly, brittle and probably > buggy Perl script. Previous iteration was commit a9c94277f0. > > Put the cleaned up system header includes first, except for the ones > the next commit will delete. > > While there, separate #include from file comment with a blank line, > > Signed-off-by: Markus Armbruster <arm...@redhat.com> > ---
> +++ b/target/i386/hvf/x86_mmu.c > @@ -15,18 +15,17 @@ > * You should have received a copy of the GNU Lesser General Public > * License along with this program; if not, see > <http://www.gnu.org/licenses/>. > */ > + > #include "qemu/osdep.h" > +#include <memory.h> <memory.h> is an obsolete spelling for the now-universal <string.h>. We should NEVER need to include it; scripts/clean-includes should be taught to blacklist this one. But that's a matter for another patch; this one does exactly what it promises, and was mechanical (even if the brittle perl script isn't published), so it's best to keep it as-is. Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
