On 01/31/2018 12:02 PM, Markus Armbruster wrote: > Got a QAPI remark, cc: Eric. > > Gerd Hoffmann <kra...@redhat.com> writes: >
>> +++ b/qapi/ui.json
>> @@ -982,3 +982,62 @@
>> 'data': { '*device': 'str',
>> '*head' : 'int',
>> 'events' : [ 'InputEvent' ] } }
>> +
>> +
>> +##
>> +# @DisplayNoOpts:
>> +#
>> +# Empty struct for displays without config options.
>> +#
>> +# Since: 2.12
>> +#
>> +##
>> +{ 'struct' : 'DisplayNoOpts',
>> + 'data' : { } }
>
> This is the fifth empty struct (QCryptoBlockInfoQCow, NetdevNoneOptions,
> Abort, CpuInfoOther), not counting the QAPI frontend's internal one.
> Perhaps we should make the internal one a full built-in type. Not this
> patch's problem, of course.
Yeah, I really need to revive my patch that would allow:
>> +{ 'union' : 'DisplayOptions',
>> + 'base' : { 'type' : 'DisplayType',
>> + '*full-screen' : 'bool',
>> + '*window-close' : 'bool',
>> + '*gl' : 'bool' },
>> + 'discriminator' : 'type',
>> + 'data' : { 'default' : 'DisplayNoOpts',
>> + 'none' : 'DisplayNoOpts',
>> + 'gtk' : 'DisplayGTK' } }
'data': { 'none': {},
'gtk': 'DisplayGTK' }
Whoa - it's been a while!
https://lists.gnu.org/archive/html/qemu-devel/2016-07/msg00311.html
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
