On 02/01/2018 09:58 AM, Daniel P. Berrangé wrote: > In this previous commit: > > commit 8f61f1c5a6bc06438a1172efa80bc7606594fa07 > Author: Daniel P. Berrange <berra...@redhat.com> > Date: Mon Dec 18 19:12:20 2017 +0000 > > ui: track how much decoded data we consumed when doing SASL encoding > > I attempted to fix a flaw with tracking how much data had actually been > processed when encoding with SASL. With that flaw, the VNC server could > mistakenly discard queued data that had not been sent. > > The fix was not quite right though, because it merely decremented the > vs->output.offset value. This is effectively to discarding data from the
s/to // > end of the pending output buffer. We actually need to discard data from > the start of the pending output buffer. We also want to free memory that > is no longer required. The correct way to handle this is to use the > buffer_advance() helper method instead of directly manipulating the > offset value. > > Reported-by: Laszlo Ersek <ler...@redhat.com> > Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> > --- > ui/vnc-auth-sasl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
