On 02/01/2018 05:47 PM, Greg Kurz wrote:
Detected by Coverity (CID 1385702). This fixes the recently added hypercall
to let guests properly apply Spectre and Meltdown workarounds.

Paolo Bonzini reported this error in a reply to the pull request that
added the patch:

"Re: [Qemu-ppc] [Qemu-devel] [PULL 12/12] target/ppc/spapr: Add H-Call H_GET_CPU_CHARACTERISTICS

On 28/01/2018 22:28, David Gibson wrote:

+    switch (safe_indirect_branch) {
+    case SPAPR_CAP_FIXED:
+        characteristics |= H_CPU_CHAR_BCCTRL_SERIALISED;

Missing "break;" here.



I think it is nice to mention in the commit msg that Paolo also detected this same error,
specially given that his email was sent before this patch.



Fixes: c59704b25473 "target/ppc/spapr: Add H-Call H_GET_CPU_CHARACTERISTICS"
Signed-off-by: Greg Kurz <gr...@kaod.org>
  hw/ppc/spapr_hcall.c |    1 +
  1 file changed, 1 insertion(+)

diff --git a/hw/ppc/spapr_hcall.c b/hw/ppc/spapr_hcall.c
index 4d0e6eb0cf1d..596f58378a40 100644
--- a/hw/ppc/spapr_hcall.c
+++ b/hw/ppc/spapr_hcall.c
@@ -1697,6 +1697,7 @@ static target_ulong h_get_cpu_characteristics(PowerPCCPU 
      switch (safe_indirect_branch) {
      case SPAPR_CAP_FIXED:
          characteristics |= H_CPU_CHAR_BCCTRL_SERIALISED;
+        break;
      default: /* broken */
          assert(safe_indirect_branch == SPAPR_CAP_BROKEN);

Reply via email to