On 02/02/2018 05:10 AM, Gerd Hoffmann wrote: > Switch over the one leftover user to qapi DisplayType. > The delete the unused request_opengl variable. > > Signed-off-by: Gerd Hoffmann <kra...@redhat.com> > --- > vl.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) >
>
> - if (request_opengl == 1 && display_opengl == 0) {
> + if (dpy.has_gl && dpy.gl && display_opengl == 0) {
> #if defined(CONFIG_OPENGL)
> error_report("OpenGL is not supported by the display");
> #else
Maybe someday when QAPI supports conditionals we can make the exposure
of the 'gl' field guarded by those conditionals, for better
introspection, rather than the current series' approach of always
exposing it then failing at runtime. But that doesn't hold up this series.
Reviewed-by: Eric Blake <ebl...@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
