Eric Blake <ebl...@redhat.com> writes:
> On 02/02/2018 07:03 AM, Markus Armbruster wrote:
>> Every generator has separate boilerplate for .h and .c, and their
>> differences are boring. All of them repeat the license note.
>>
>> Reduce the repetition as follows. Move common text like the license
>> note to common open_output(), next to the existintg common text there.
>
> s/existintg/existing/
Fixing...
>> For each generator, replace the two separate descriptions by a single
>> one.
>>
>> While there, emit an "automatically generated" note into generated
>> documentation, too.
>>
>> Signed-off-by: Markus Armbruster <arm...@redhat.com>
>> ---
>
>> +++ b/scripts/qapi2texi.py
>> @@ -282,7 +282,8 @@ def main(argv):
>> print >>sys.stderr, ("%s: need pragma 'doc-required' "
>> "to generate documentation" % argv[0])
>> sys.exit(1)
>> - print texi_schema(schema)
>> + print '@c AUTOMATICALLY GENERATED, DO NOT MODIFY\n'
>> + print texi_schema(schema),
>
> Spurious addition of trailing comma. Otherwise,
This is Python's (rather unobvious) way to print without adding a
newline.
> Reviewed-by: Eric Blake <ebl...@redhat.com>
Thanks!
